Repository navigation
test(desktop): make MermaidRenderer tests independent of order - #210
Merged
Merged
Conversation
GoDiao
approved these changes
Oct 30, 2026
GoDiao
left a comment
Owner
There was a problem hiding this comment.
Thanks @KingEmma7, and welcome! This is the fix #206 suggested: the test no longer clears initializeMock, and it now asserts that initialize ran exactly once. We ran the file with your seeds (1, 2, 3, 11 and 23) and in file order, and all pass. With the old test file, seed 11 fails the first test, so your reproduction holds.
We pushed one small commit on top that removes the CHANGELOG entry. The changelog lists changes users can see, and this PR only changes a test, so it gets no entry (earlier test-only PRs didn't either).
Approving and merging. If you find DreamCoder useful, a ⭐ on the repo would mean a lot to us. Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #206.
Keep
initializeMockhistory for the lifetime of the cached Mermaid module and assert that initialization ran exactly once.renderMockstill resets before each test. Includes the required changelog entry; production code is unchanged.Validation on
69e4c954(macOS arm64, Bun 1.4.3, Node 24.19.0):bun run lint: passed.bun run test -- --run: 1,618 passed, 4 skipped across 159 files.Local server-test limitation and command
Three tests in
src/server/__tests__/filesystem.test.tscreate fixtures directly in the user's home directory. Local write restrictions prevented those tests, so they remain unverified locally. The remaining server tests ran with local service access. The unfiltered server suite is not claimed as passing.