Skip to content

Patch OpenAL MSVC Warning on UniquePtr definitions - #174

Merged
mallory-scotton merged 2 commits into
mainfrom
ms/hotfix-msvc-fix-openal
Nov 19, 2026
Merged

mallory-scotton merged 2 commits into
mainfrom
ms/hotfix-msvc-fix-openal

Conversation

@mallory-scotton

Copy link
Copy Markdown
Member

Type of Change

  • 🐞 Bug Fix (non-breaking change which fixes an issue)
  • ✨ New Feature (non-breaking change which adds functionality)
  • 💥 Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • 🧹 Refactor (code cleanup, architectural improvement, or progressive abstraction)
  • 📖 Documentation Update
  • 🧪 Tests / CI / Build System (CMake) Update

Description

Simple fix by applying a patch file to the CMakeLists.

Checklist

  • My code follows the gp-engine C++ Coding Standard.
  • I have compiled the engine successfully using the modern C++23 toolchain (GCC 13+, Clang 16+, or MSVC 19.38+) and CMake.
  • I have performed a self-review of my code and added comments, especially in complex areas like shader programming or math-heavy algorithms.
  • I have updated the relevant API reference or learning path documentation (if applicable).
  • My changes generate no new compiler warnings in the build log.
  • I have read and agree to the Code of Conduct and Contributing Guidelines.

GP Contributor License Agreement

I give to the Graphical Playground Team, LLC permission to license my contributions on any terms
they like. I am giving them this license in order to make it possible for them to accept my
contributions into their project.

As far as the law allows, my contributions come as is, without any warranty or condition, and I
will not be liable to anyone for any damages related to this software or this license, under any
kind of legal claim.

@mallory-scotton
mallory-scotton requested a review from a team as a code owner November 19, 2026 12:45
@mallory-scotton mallory-scotton self-assigned this Nov 19, 2026
@github-actions github-actions Bot added topic:thirdparty Involves a third-party library or dependency topic:buildsystem Involves the build system labels Nov 19, 2026
@mallory-scotton
mallory-scotton requested a review from a team as a code owner November 19, 2026 12:51

@natan-fievet natan-fievet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no issues at all, functional build and tests for updated version of visual studio community 18.12.1

@mallory-scotton
mallory-scotton merged commit 221ac4c into main Nov 19, 2026
10 checks passed
@mallory-scotton
mallory-scotton deleted the ms/hotfix-msvc-fix-openal branch November 19, 2026 13:05
@github-project-automation github-project-automation Bot moved this from Todo to Done in Engine Issues Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:buildsystem Involves the build system topic:thirdparty Involves a third-party library or dependency

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants