Skip to content

Node panics shouldn't bring down the editor #1552

Closed
Feature
#1846
Closed
Node panics shouldn't bring down the editor#1552
Feature
#1846
Assignees
TrueDoctor
Labels
ArchitectureInvolves architecture or engineering work or discussionGrapheneInvolves the node graph system/engine used by Graphite
Milestone
Milestone 39

Description

@Keavon
Keavon
opened on Jan 7, 2024

Sandbox various components, like the node graph, in panic handlers. Reload those components instead of having to reload the whole page. Avoid making the document get lost since that's highly destructive to the user and almost always shouldn't be corrupted by whatever bug resulted in the crash, so the document data should most likely be in tact.

Some options:

  • Move the graph evaluator into a web worker?
  • Something with panic handlers?
  • Reboot the node graph executor somehow?

Activity

  1. Keavon
    added
    Feature
    Rust
    Paper CutA small UX annoyance we should strive to improve
    GrapheneInvolves the node graph system/engine used by Graphite
    on Jan 7, 2024
  2. Keavon
    assigned
    TrueDoctor
    on Jan 7, 2024
  3. github-project-automation
    added this to Task Boardon Jan 7, 2024
  4. github-project-automation
    moved this to Short-Term in Task Boardon Jan 7, 2024
  5. Keavon
    added
    ArchitectureInvolves architecture or engineering work or discussion
    and removed
    Paper CutA small UX annoyance we should strive to improve
    on Jan 14, 2024
  6. Keavon
    changed the title [-]Make node panics not bring down the editor[/-] [+]Node panics shouldn't bring down the editor[/+] on Jun 9, 2024
  7. TrueDoctor
    moved this from Short-Term to In-Progress Tasks in Task Boardon Jul 24, 2024

  8. TrueDoctor commented on Aug 4, 2024

    @TrueDoctor
    TrueDoctor
    on Aug 4, 2024
    Member

    @Keavon should we close this or remove it from the in progress tasks?

  9. Keavon commented on Aug 4, 2024

    @Keavon
    Keavon
    on Aug 4, 2024
    MemberAuthor

    Closed by #1846

  10. Keavon
    closed this as completedon Aug 4, 2024
  11. github-project-automation
    moved this from In-Progress Tasks to Tasks Completed This Sprint in Task Boardon Aug 4, 2024
  12. Keavon
    added this to the Sprint 39 milestone on Aug 4, 2024
  13. Keavon
    added a parent issue on Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

ArchitectureInvolves architecture or engineering work or discussionGrapheneInvolves the node graph system/engine used by Graphite

Type

Feature

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions