feat(engine): add graceful exhaustion and deterministic replay cache - #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the remaining herm follow-ups (from PR #254's notes): graceful exhaustion and a deterministic replay cache. (The third noted item — staged skills mount — was dropped after analysis: hawk already injects only name+description into the prompt with digest-based incremental catalog updates and loads skill content on invocation, so the lazy-content pattern is already in place.)
1. Graceful turn-budget exhaustion synthesis (
internal/engine/stream_exhaustion.go)gracefulExhaustion: when the agent loop hits its limits (turn limit, token/time budget viacheckGuardConditions), instead of emitting a bare "Limit reached" line it makes one final tools-disabled LLM call (Session.SynthesisForExhaustion) that synthesizes a coherent completion: what was accomplished, what remains, next steps.checkGuardConditions.2. Deterministic replay cache (
internal/replaycache)HAWK_REPLAY_CACHE_DIRroutesChatService.Chatthrough the cache (chatWithReplay); unset (default) leaves the chat path byte-for-byte untouched.HAWK_REPLAY_FINGERPRINTinvalidates whole suites at once. Writes are atomic 0600; errors are never cached.Verification
go build ./...,go vet, full engine + replaycache suites green