Repository navigation
Bump yampVersion to 26.11.16 - #155
Open
Grigory-Rylov wants to merge 2 commits into
Open
Grigory-Rylov wants to merge 2 commits into
Grigory-Rylov wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Release
v26.11.11assets were silently replaced.app-build.ymlattaches DMG/Linux-zip to the release taggedv<yampVersion>on every master push; becauseyampVersionwas not bumped afterb0854f3landed, the Nov 13 master push rebuilt and overwrote the assets of the already-publishedv26.11.11(originally released Nov 10), while the tagv26.11.11still points to1693bec. One version number now means two different binaries: downloads before Nov 13 do not contain the pinch fix, downloads after it do.Bumping
yampVersionto26.11.16gives the current master state honestly versioned artifacts: freshYAMP-26.11.16.dmg,YAMP-26.11.16-linux.zipandyamp_plugin_26.11.16.zipunder a new tag.What is in this release (1693bec → b0854f3)
macOS pinch-to-zoom must never die silently in AS plugin mode (
b0854f3, #154)onMagnifynow returnsboolean, and when the bridge cannot deliver (panel not in hierarchy, listeners empty, channel mid-install) theNSEventmonitor passes the event through, so the JBR/OS ctrl+wheel emulation still zooms.NSEventlocal monitor is now retained: the autoreleased monitor died with the autorelease-pool drain inside the IntelliJ EDT (standalone AppKit never drains it there — hence the "sometimes" in "pinch sometimes dies in the Android Studio plugin").Flame chart rebuilt on the racing virtual-space component (#151)
Report
Recent profiles
Build/CI
e5ab2f3, Attach plugin zip to release even when tag already exists #153).build-plugin.ymlnow also builds the plugin zip on PRopened/synchronize/reopenedevents and uploads it to the workflow run as theyamp_plugin_<version>artifact, so the plugin can be tested from the PR itself before merge. The release-attach step still runs only on a merged PR — an open PR never touches published releases.Follow-up idea (not in this PR)
Disallow
app-build.ymlfrom overwriting assets of an already-published release tag, so a forgotten version bump fails loudly instead of silently swapping binaries users already downloaded.