Skip to content

[Feature] 让HMCL可以识别到内嵌模组，增加模组关系检测及级联处理 - #6230

Open
Lokins577 wants to merge 18 commits into
HMCL-dev:mainfrom
Lokins577:5332JIJv2.0
Open

[Feature] 让HMCL可以识别到内嵌模组，增加模组关系检测及级联处理#6230
Lokins577 wants to merge 18 commits into
HMCL-dev:mainfrom
Lokins577:5332JIJv2.0

Conversation

@Lokins577

@Lokins577 Lokins577 commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

让HMCL可以识别到内嵌模组并以下拉列表的形式显示，在崩溃时若有JIJ信息一并打包至压缩包内；增加对模组依赖关系的分析，可直接查看当前模组前置安装状态，禁用模组时检测以该模组为前置的模组并进行提示

  • 内嵌模组检测
  • 模组关系检测
  • 模组禁用/删除级联处理
  • 模组安装页展示前置模组安装状态

@Lokins577

Lokins577 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

#5332

@Lokins577 Lokins577 changed the title [Feature] 让HMCL可以识别到JIJ的打包形式并以下拉列表的形式显示，并支持搜索和导出JIJ信息，且在崩溃时若有JIJ信息则一并打包至压缩包内 [Feature] 让HMCL可以识别到内嵌模组，增加模组关系检测 Jun 26, 2026
@Lokins577 Lokins577 changed the title [Feature] 让HMCL可以识别到内嵌模组，增加模组关系检测 [Feature] 让HMCL可以识别到内嵌模组，增加模组关系检测及级联处理 Jun 27, 2026
@Lokins577
Lokins577 marked this pull request as ready for review July 1, 2026 16:43
@Lokins577

Lokins577 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

cc @3gf8jv4dv

3gf8jv4dv
3gf8jv4dv reviewed Jul 10, 2026
View reviewed changes
Comment thread HMCL/src/main/resources/assets/lang/I18N_zh.properties Outdated
@Lokins577 @3gf8jv4dv
Update HMCL/src/main/resources/assets/lang/I18N_zh.properties
60272e3 
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
3gf8jv4dv
3gf8jv4dv reviewed Jul 10, 2026
View reviewed changes

@3gf8jv4dv 3gf8jv4dv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, it’s wonderful.

Image

@Glavo

Glavo commented Jul 11, 2026

Copy link
Copy Markdown
Member

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 11, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 60272e3790

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/addon/mod/ModManager.java
Glavo
Glavo reviewed Jul 12, 2026
View reviewed changes

@Glavo Glavo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本审查建议由 GPT-5 生成

已将具体审查建议标注在对应代码行。

Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/addon/meta/QuiltModMetadata.java Outdated
Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/addon/meta/FabricModMetadata.java Outdated
Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPageSkin.java Outdated
Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPageSkin.java Outdated
Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPageSkin.java Outdated
Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPageSkin.java Outdated
Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java
Glavo
Glavo reviewed Jul 16, 2026
View reviewed changes

@Glavo Glavo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本审查建议由 GPT-5.6 Sol 生成

已将具体审查建议标注在对应代码行。

Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/addon/mod/NestedJarInspector.java Outdated
Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPageSkin.java
Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPage.java
Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/addon/mod/MinecraftVersionMatcher.java Outdated
Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/addon/mod/ModManager.java
Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java Outdated
Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPageSkin.java Outdated
@github-actions github-actions Bot added the 2000+ label Jul 17, 2026
@Lokins577
修复已知问题
adb9438 
更改由opus 4.8审查并添加注释
@Lokins577 Lokins577 mentioned this pull request Jul 19, 2026
Open
4 tasks
@Glavo

Glavo commented Jul 29, 2026

Copy link
Copy Markdown
Member

感觉这个 PR 实现的很奇怪。我们可能需要先好好思考一下 HMCL 读取这些内容时的线程模型，而不是像这个 PR 搞得到处是锁，到处上 ConcurrentHashMap。

@Lokins577 Lokins577 mentioned this pull request Aug 1, 2026
Open
@Lokins577

Lokins577 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

等待Glavo重构相关模型

@Minecraft269

Minecraft269 commented Aug 3, 2026

Copy link
Copy Markdown

等待Glavo重构相关模型

那这个PR是不是得切换到 draft 状态?

@Minecraft269 Minecraft269 mentioned this pull request Aug 27, 2026
Open
@ToobLac

ToobLac commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

依靠 mod id 进行的依赖检测大抵是不可靠的吧？我觉得就算做依赖关系也应该把远程和本地的逻辑做成不一样的。本地可以用 mod id 和 version predicate 判断，远程个人认为还是用 hash 比较靠谱

参考 #6723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Glavo Glavo Glavo left review comments
@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
+1 more reviewer
@3gf8jv4dv 3gf8jv4dv 3gf8jv4dv left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2000+

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Lokins577 @Glavo @Minecraft269 @ToobLac @3gf8jv4dv