Fix display of mod with extra long display name - #6436
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves text wrapping and truncation behavior in the UI. In TwoLineListItem, lblTitle is configured to grow with a minimum width of 0. In ModListPageSkin, text wrapping is enabled for the mod info dialog title, and text overrun is set to ellipsis for the mod info list cell. The review feedback suggests two layout refinements: setting HBox.setHgrow(tagsBox, Priority.NEVER) in TwoLineListItem to prevent premature truncation of the title, and setting HBox.setHgrow(title, Priority.ALWAYS) in ModInfoDialog to ensure the title properly wraps within the available width.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
这个问题在 #5435 顺带修了 但是那个PR不知道什么时候才能合并 所以挺好 |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcca2441e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bcca244 to
4eee224
Compare
|
你好 我最近也在关注此问题 特与你来交流 |
|
换行展示有尝试过，但是名字与标签两者之间总有一个太窄，就放弃了。我是觉得列表里名字不全无所谓，只要有对应的详细页面可以完整展示名字就行 |
|
标签依然会挤压标题 
|
|
github action有点古怪，我本地 
|
|
5 participants
共两个commits。第一个commit修复了在模组列表里名称（+译名）非常长的模组会将右侧的两个按钮挤走的问题：
既然列表里名字不一定是全名，那就另外需要一处可以展示全名的界面。第二个commit修复了详细信息页面里超长模组名的显示问题：