Skip to content

[Chores] 移动 ModListPageSkin 到 ModListPage 内部 - #6729

Merged
Glavo merged 1 commit into
HMCL-dev:mainfrom
ToobLac:modlistpageskin
Sep 2, 2026
Merged

[Chores] 移动 ModListPageSkin 到 ModListPage 内部#6729
Glavo merged 1 commit into
HMCL-dev:mainfrom
ToobLac:modlistpageskin

Conversation

@ToobLac

@ToobLac ToobLac commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the 1000+ label Aug 23, 2026
@Glavo

Glavo commented Aug 31, 2026

Copy link
Copy Markdown
Member

有必要吗?

@ToobLac

ToobLac commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

有必要吗?

把这个 Skin 暴露出来本来就不是很合适吧。这导致 ModListPage 和 Skin 里面都有很多东西设置成了 package-private,在权限管理方面不是很合适。

@Glavo

Glavo commented Sep 2, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T12:34:01.471057Z 3e17882 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Glavo
Glavo merged commit cb69387 into HMCL-dev:main Sep 2, 2026
3 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 3e17882591

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ToobLac
ToobLac deleted the modlistpageskin branch September 3, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants