Skip to content

fix: 初次进入新增游戏目录页面不会自动填充 .minecraft 上级目录名称 - #6764

Merged
Glavo merged 1 commit into
HMCL-dev:mainfrom
CiiLu:tare/b
Aug 31, 2026
Merged

fix: 初次进入新增游戏目录页面不会自动填充 .minecraft 上级目录名称#6764
Glavo merged 1 commit into
HMCL-dev:mainfrom
CiiLu:tare/b

Conversation

@CiiLu

@CiiLu CiiLu commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the 10+ label Aug 28, 2026
@Glavo

Glavo commented Aug 31, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T13:22:26.667196Z 68422cb Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Glavo
Glavo merged commit b1759ac into HMCL-dev:main Aug 31, 2026
3 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 68422cb553

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

txtGameDirectoryName.setText(suggestedName);
}
};
locationChangeListener.changed(null, this.location.get(), this.location.get());

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve existing names when initializing the suggestion

When this page is constructed with a non-null directory whose path ends in .minecraft, this unconditional callback replaces the existing gameDirectoryDisplayName already placed in the text field with the parent folder name. For example, editing a directory named Work at /games/foo/.minecraft immediately changes the field to foo, and saving persists that unintended rename; run the initial suggestion only when creating a new entry.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants