fix: 实例列表中新快照图标错误 - #6774
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d09db6a584
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (version.isAprilFools()) | ||
| return GameInstanceIconType.APRIL_FOOLS.getIcon(); | ||
| else if (version instanceof GameVersionNumber.LegacySnapshot) | ||
| else if (version instanceof GameVersionNumber.LegacySnapshot || version instanceof GameVersionNumber.Release release && release.getEaType() != GameVersionNumber.Release.ReleaseType.GA) |
There was a problem hiding this comment.
When version detection returns no result or cannot resolve the primary JAR, DefaultGameInstance.detectVersion() returns GameVersionNumber.unknown(), which is the Release.ZERO instance with ReleaseType.UNKNOWN. Because UNKNOWN != GA, this condition now classifies such instances as snapshots and displays the command-block icon instead of the previous grass fallback. Restrict this branch to the actual early-access release types, or explicitly exclude GameVersionNumber.unknown().
Useful? React with 👍 / 👎.
2 participants
No description provided.