Improve the Main Window Layout - #21
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4872e6ecc3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| MinHeight="918" | ||
| MaxHeight="918" | ||
| CanResize="False" |
There was a problem hiding this comment.
Let the main window fit the working area
On displays whose logical working height is below 918 pixels—such as a 1366×768 laptop or many 1080p displays using 125% scaling—the fixed minimum/maximum height combined with CanResize="False" makes part of the window extend beyond the desktop. Because the internal viewport still measures the oversized window rather than the visible portion, controls near the bottom can remain inaccessible; size the window relative to the working area or allow users to shrink it.
Useful? React with 👍 / 👎.
| MinHeight="918" | ||
| MaxHeight="918" | ||
| CanResize="False" | ||
| WindowStartupLocation="CenterScreen" |
There was a problem hiding this comment.
Preserve restored positions after startup
For returning users with a saved window position, ApplyWindowPlacement assigns Position in the constructor before the window is shown, but CenterScreen applies the startup placement during the initial show and replaces that restored position. Use centered startup only when no saved position exists, and leave startup placement manual when restoring one.
Useful? React with 👍 / 👎.
|
Thanks for this. The spacing and padding work is good and I want it, but I am not taking the fixed window size, and the PR needs a rebase either way. Rebase first. #20 went in on The part I want changed: Two concrete problems:
What I would take instead: keep everything else, and replace the six size properties and MinWidth="960"
MinHeight="640"
Width="1207"
Height="918"
WindowStartupLocation="CenterScreen"That gives you the intended default size and stops the layout from being squeezed into the shape you were fixing, without taking resizing away. If the goal was specifically that the cards stop growing too tall around 1000px, a Also dropping the saved size and maximized state in Happy to merge once the fixed size is gone and it is rebased on current |
Improve the Main Window Layout
Summary
This change makes the main window use a fixed 1207 by 918 size.
The user cannot resize the window.
The first start puts the window at the center of the screen.
The layout now stays horizontal at widths from 960 pixels.
The compact layout starts only below 960 pixels.
This prevents the main cards from becoming too tall at about 1000 pixels.
User Interface Changes
Window Size and Position
The XAML window now sets its width and height to 1207 and 918.
It also sets the same minimum and maximum values.
CanResizeis false.The window placement code now restores only a valid saved position.
It does not restore an old width, height, or maximized state.
The code sets the fixed size before the window opens.
Tests and Build
dotnet buildin Release configuration.Output