.NET Core support

Ideally HdrHistogram should be available on all supported versions of .NET.
Currently this is 4.5.2 & 4.6.1
It may however be prudent to wait until .NET Core and supporting tooling is available before undertaking this task, as it may incur alot of rework if the goalposts move by too much.

Any movement on a .net core or better yet a build for .net standard?

@qooroo

There was an early attempt to port to DNX, but just as @qooroo and I started making progress, things changed (beta, dnx vs dotnet, pcl/core/standard etc). Now that .NET Standard seems to be settling down as the way to package libs, I will look at that.
Help is appreciated, else I will probably see what Json.NET has done and copy him.

OK, this is only my list, happy to help out when I get to it if not done by then

@LeeCampbell

@LeeCampbell I've ported the main library to .NET Standard, there wasn't too much to do there.

There is however an issue with the benchmarking project, there's no .net core build for BenchmarkDotNet.Diagnostics.Windows so we wouldn't be able to make use of the MemoryDiagnoser

I could leave the HdrHistogram.Benchmarking as a .net 4.6.1 project however csproj with xproj references don't work, the benchmark project would have to reference HdrHistogram as a nuget package.

Thoughts?

Actually I can reference HdrHistogram.xproj using a reference with a hint path rather than a project reference, happy with this approach? i.e.

 <Reference Include="HdrHistogram">
      <HintPath>..\HdrHistogram\bin\Debug\net461\HdrHistogram.dll</HintPath>
    </Reference>

@alhardy

Thanks for chasing this up @alhardy. The goal of the MemoryDiagnoser in the Benchmark is purely to ensure that we are not allocating on the hot path. However, this isn't part of an automated rig that can fail the build if we do. So if we cant have the .NET Framework specific code then so be it.

However I do like your work around. Are you able to set up a Pull Request? I will pull down locally and see if it plays nicely on my machine too.

HdrHistogram#17 git excluded IsLastValueBug.hgrm on last merge

HdrHistogram#17 fixing default namespace in unit test project

@alhardy

@alhardy HdrHistogram#17 HdrHistogram targeting .NET Standard, nunit …

@alhardy

@alhardy HdrHistogram#17 HdrHistogram targeting .NET Standard, nunit …

@alhardy

@alhardy HdrHistogram#17 HdrHistogram targeting .NET Standard, nunit …

@alhardy

@alhardy HdrHistogram#17 HdrHistogram targeting .NET Standard, nunit …

@LeeCampbell

@LeeCampbell : Hi, could you provide status on this. When will we be able to reference/restore a release that has .NET Core and .NET Framework support.

Thanks

Really sorry about the delay on this one.
Plan is to pave my machine and get Vs2017 and the new .NET Core tools installed.
Hopefully they work nicely. This will be the 4th attempt at doing this. First attempt was back in 2015 :-(

@LeeCampbell

@LeeCampbell : No problem... is there a nuget feed I can restore from that has builds of this version (i.e. .NET Core and .NET Framework supported) available. Maybe the appveyor project feed?

@alhardy

@alhardy HdrHistogram#17 HdrHistogram targeting .NET Standard, nunit …

@dtillman

@dtillman Can you check if https://ci.appveyor.com/nuget/hdrhistogram-net-7o4w2wn7lgf9 gives you what you need.
Version HdrHistogram.1.24.0-eekpfsxs-PR52.nupkg is the result of the #52 Pull Request. Currently untested, but it would be great to get your feedback if you have the time/appetite/motivation

Tested locally, but on the same machine that it was developed on. I may release this as pre-release on Nuget.

@LeeCampbell

@LeeCampbell : Thanks.. I've pulled it in and I'm currently using it/testing and all seems to be working fine on .NET Core 1.1 ... If I run into any issues I'll be sure to report...
Let me know if you publish a pre-release someplace .. and I'll switch over to that...
Thanks again for the support!
Dave

A complete re-attempt to solve this with VS2017 on a clean Win10 PC is available from #58 and via nuget on https://ci.appveyor.com/nuget/hdrhistogram-net-7o4w2wn7lgf9 as version 2.24.0-xeywwypu-PR58

Navigation Menu

Repository navigation

.NET Core support #17

15 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

.NET Core support #17

Description

Activity

alhardy commented on Oct 30, 2016

LeeCampbell commented on Oct 31, 2016

alhardy commented on Nov 2, 2016

alhardy commented on Nov 28, 2016

alhardy commented on Nov 28, 2016

LeeCampbell commented on Nov 28, 2016

15 remaining items

dtillman commented on May 22, 2017

LeeCampbell commented on May 25, 2017

dtillman commented on May 25, 2017

LeeCampbell commented on May 26, 2017

LeeCampbell commented on May 26, 2017

dtillman commented on May 27, 2017

LeeCampbell commented on Jun 3, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions