Repository navigation
Resolve inherited components when collecting query rows - #60
Merged
HexDecimal merged 1 commit intoOct 15, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 9 9
Lines 956 959 +3
=======================================
+ Hits 948 951 +3
Misses 8 8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
HexDecimal
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a prefab gets a component and a child is created with
instantiate(),registry.Q.all_of(components=[int])finds both entities. Collecting the same component withregistry.Q[Entity, int]raisesKeyErrorfor the child because row collection reads only direct component storage.Keep the direct-storage path for ordinary columns and fall back to entity component access for columns containing inherited values. Add regressions for named and unnamed components, inherited
None, nested instances, overrides, removal and repeated columns, plus a changelog note.Validation: 84 tests pass with two existing XPASS results; strict mypy and applicable pre-commit hooks pass. In 32 simulated game-turn workflows checked against a separate plain-dictionary world, all 24 previously failing inherited-component scenarios complete. Eight direct-component controls are unchanged. Save/load and live prefab updates are included.