Repository navigation
Snapshot inherited component relation inputs before replacement - #62
Merged
HexDecimal merged 2 commits intoOct 15, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 9 9
Lines 965 966 +1
=======================================
+ Hits 957 958 +1
Misses 8 8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
HexDecimal
approved these changes
Oct 15, 2026
HexDecimal
left a comment
Owner
There was a problem hiding this comment.
Treating these as collections has been awkward with how Python references everything. At least the solution to these issues is often to simply make a copy of the mutable state before processing.
Thanks for more of these fixes and tests.
| ### Fixed | ||
|
|
||
| - Replacing component relations from an inherited view now preserves values which depend on the destination. | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Removed the extra blank line. Thanks for reviewing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing a prefab's component relations from an instance's inherited mapping silently loses values: clearing the destination also changes the live source before its items are read.
Snapshot the input pairs before clearing the destination, matching the existing approach for tag-relation assignment. Component objects are retained by reference; this adds an O(n) temporary tuple of pairs. The same-entity/same-key no-op guard stays unchanged. Add regressions for named/unnamed keys, one/three inheritance levels, overrides and warmed queries, plus a changelog entry.
Validation on current main
07ba4b8(including #61):This is separate from #59's distinct-key no-op guard and #61's overlapping tag/component query indexes: the input here inherits data from the destination being replaced.