Repository navigation
Return no matches for contradictory query filters - #66
Merged
HexDecimal merged 2 commits intoOct 19, 2026
Merged
Conversation
Owner
|
It is a contradictory state. It makes sense to remove the assertion error, but I wonder if at least a warning should be raised. Or is this state so obvious that it warrants no runtime warnings at all? |
Contributor
Author
|
Overlap can be an expected empty result when independent filters are combined, for example a required |
HexDecimal
approved these changes
Oct 19, 2026
HexDecimal
left a comment
Owner
There was a problem hiding this comment.
I think you're right. It was a mistake for me to give this case special attention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
registry.Q.all_of(tags=["actor"]).none_of(tags=["actor"])raises an internalAssertionErrorwhile constructing the query. This makes dynamically composed filters fail when a required condition is also excluded, instead of producing an empty result.Remove the disjointness assertion. The existing intersection/difference compiler already evaluates these conjunctions correctly, including normal cache invalidation.
Validation:
This is independent of #65's cache ownership change.
OpenAI Codex assisted with investigation, implementation and validation.