Remove openMINDS v3 /v4 adapters now that the KG is on v4 - #112
Merged
Conversation
Drops the KGClient.migrated feature-detect probe and all of the v3/v4 namespace adapters that were used to translate property, type and instance URIs. Also updates the queries.py docstring examples.
apdavison
added
the
task
Resolves two conflicts against the 0.14.0 instance-recast changes: keep only the LinkedNodeEmbedding and ErrorHandling imports in utility.py (lookup_type and OPENMINDS_VERSION were used solely by the removed v3 adapters), and drop test_adapt_namespaces while keeping the three tests added on master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the KGClient.migrated feature-detect probe and all of the v3/v4 namespace adapters that were used to translate property, type and instance URIs. Also updates the queries.py docstring examples.