Handle non-openMINDS types in space_info() instead of raising - #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113.
A KG space can contain types that have no fairgraph class — the KG's own internal types, such as
https://core.kg.ebrains.eu/doi/AdditionalDoiInformation.space_info()raisedValueErrorfor those, so a single unrecognised type made the whole space listing fail.Unrecognised types are now returned keyed by their type IRI rather than by a class. The
ignore_errorsargument and the hard-coded ignore list it guarded are both gone.clean_space()andmove_all_to_space()cope with the string-keyed entries, operating on the raw type IRI rather than skipping them.Regression tests added in
test/test_client.py; they need a KG connection and skip without one.