Return None from from_id() for a non-existent id on the untyped path - #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115.
KGObject.from_id()called on the base class, where the type isn't known up front, indexed into the result ofinstance_from_full_uri()without checking it. That returnsNonefor an instance that doesn't exist or isn't accessible, so the call raisedTypeError: 'NoneType' object is not subscriptableinstead of returningNone.The typed path already handles this correctly in
from_uri(), andfrom_id's own docstring states thatNonemeans the object doesn't exist or the user lacks permission. Only the untyped branch was wrong.Tests in
test/test_base.pycover both theNoneresult and the success path. Both run offline against the mock client.