Skip to content

[Impl] No field identifies the advertiser or brand a commitment is for #126

Open

Description

@EvgenyAndroid

What did you build?

An implementation that parses and validates OpenProposal proposals, line items and commitments end to end.

What you tried to express, and what happened

I tried to resolve which party a buyer's commitment binds. The only buyer-side identifiers in the draft are brief_ref, eligible_bidders[], and the supplied half of buyer_requirements (dsp_seat_id, dsp_id, seat_owner_entity). seat_owner_entity names who owns the DSP seat, which is often the agency rather than the advertiser. Nothing says which advertiser or brand a commitment binds. A commitment therefore carries an amount and dates with no named party it's for.

What you did instead

Took the advertiser and brand from outside the object, from the authenticated context of the request, and refused to proceed when they're missing.

Suggested resolution: either add an advertiser/brand identity (with its namespace) to the proposal or the commitment, or state that party identity belongs to the transport binding and is out of scope for the object. #57's authorization-evidence point is adjacent but separate: that is about who approved the spend, this is about who the spend is for.

Fields involved

commitment, buyer_requirements, brief_ref, eligible_bidders[]

How blocking was it?

Workaround required, but it works

Before you submit

  • I have read CONTRIBUTING.md and agree my contribution may be published under this repository's licence.
  • This contains no confidential or commercially sensitive information — no real rate cards, deal terms, client names or inventory data.

Activity

  1. KonstantinMirin commented on Nov 4, 2026

    @KonstantinMirin

    Thanks, @EvgenyAndroid. Postindustria (IAB Tech Lab member) supports your first option, and the PR on who the parties are adopts it for the advertiser. The record names the entity that assents, usually the agency, as buyer. commitment.advertisers[] names whom the spend is for. Each is a Party identified by its domain, which serves as its namespace. advertisers[] is REQUIRED on a commit, as you ask on the rules issue, in our signing PR.

    Revised 2026-11-05: advertisers[] is REQUIRED.

    Analyzed and generated with the help of Claude, fully reviewed by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions