Skip to content

[WIP] 48131: ‘Focus’ not displayed correctly in main menu and modal - #12343

Open
alex40724 wants to merge 2 commits into
ILIAS-eLearning:release_10from
leifos-gmbh:fix_48131
Open

alex40724 wants to merge 2 commits into
ILIAS-eLearning:release_10from
leifos-gmbh:fix_48131

Conversation

@alex40724

@alex40724 alex40724 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

This PR is adressing mainly https://mantis.ilias.de/view.php?id=48131, but also other focus issues.

Other issues being adressed:

  • When entering a slate submenu using keyboard tabs and subsequently walking backwards using shift-tab the focus does not end up in the initial main menu entry. It is always moved to the end of the main menu instead.
  • On some elements, e.g. tabs, the focus frame is shown "on-click". This is not necessary, the focus is being used for keyboard tab navigation.
  • The use of border for the focus makes glyphs or text move inside buttons or links sometimes. An outline-only variant prevents this.

Open Issue: Tab on Main Menu should open first entry.

@alex40724 alex40724 added bugfix kitchen sink css/html Pull requests that propose changes to CSS/SCSS or HTML files. labels Nov 2, 2026
@alex40724
alex40724 requested a review from rotegras November 4, 2026 09:15
@thibsy thibsy self-assigned this Nov 4, 2026

@Annett7811 Annett7811 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @alex40724!

Thank you very much for the PR and the improvements to focus control and keyboard navigation!

From my perspective, the changes described make a lot of sense, especially the correct back navigation with Shift+Tab, the distinction between mouse and keyboard focus, and the use of outline instead of border to prevent layout shifts.

In my opinion, one more improvement would be desirable: When navigating with the keyboard, pressing the Tab key to enter the main menu should first focus on the first menu item.

I would appreciate it if this could be included in this PR, as it is directly related to the improvements made to focus control and contributes to consistent keyboard navigation.

Otherwise, I think the changes are very welcome. Thank you very much for implementing them!

Best regards
@Annett7811

@alex40724

Copy link
Copy Markdown
Member Author

Hello @Annett7811,

thank you very much for your valuable feedback. I added this change.

Best regrads,
Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix css/html Pull requests that propose changes to CSS/SCSS or HTML files. kitchen sink

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants