Repository navigation
Refinery/Math: Mantis 48370 numeric bounds - #12357
Merged
thojou merged 1 commit intoNov 10, 2026
Merged
Conversation
mjansenDatabay
approved these changes
Nov 3, 2026
See: https://mantis.ilias.de/view.php?id=48370 A numeric question bound such as 5.4E+24 was stored as 0. KindlyTo float rejected that text, and the request collector replaced the failure with 0. PHP prints the parsed value back as 5.4E+24, so the next save of 54E23 became 0 as well. EvalMath read the plus as addition with the constant e, so the same text scored as about 38.68. FloatTransformation now accepts a decimal mantissa and an exponent sign. EvalMath consumes the plus and evaluates the magnitude as a power of ten. The ILIAS copyright header stays first in EvalMath, and the notation tests compare values that fit the PHP adapter.
thojou
force-pushed
the
hotfix/10/48370-numeric-bounds
branch
from
November 10, 2026 12:45
9367e4a to
432202b
Compare
Contributor
Author
|
Hey all, There is currently no authority assigned to Math. @mjansenDatabay has approved the changes related to Refinary. Since these changes are required to resolve an issue in Test & Assessment, I will merge them now. Kind regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://mantis.ilias.de/view.php?id=48370
Why
A numeric question bound such as
5.4E+24was stored as 0. KindlyTo float rejected that text, and the request collector replaced the failure with 0. PHP prints the parsed value back as5.4E+24, so the next save of54E23became 0 as well. EvalMath read the plus as addition with the constant e, so the same text scored as about 38.68.What changed
FloatTransformationaccepts a decimal mantissa and an exponent sign.EvalMathconsumes the plus and evaluates the magnitude as a power of ten.Scope
EvalMathpath.Blast Radius
Any input that uses KindlyTo float can now send a decimal mantissa or an exponent sign.
7E10still parses.1E+2means 100.Verification
FloatTransformationTestandilMathTestfailed on5.4E+24before the fix and passed after it.5.4E+24and5.6E+24. The second parse of the printed form kept both values.5.4E+24compared with100is rejected.There is currently no active authority for Math. So maybe you could shepherd the Math changes.
Kind regards,
@thojou