Repository navigation
Conversation
thibsy
added
kitchen sink
improvement
php
thibsy
force-pushed
the
feature/12/ui-data-table-prompts
branch
from
November 9, 2026 09:36
eb72f0f to
400cc37
Compare
Contributor
Author
|
@kergomard your prompt usage was not a simple "make this an URL builder" fix, I am not entirely sure if the changes produce the same behaviour. Perhaps you can have a look? I think it depends on how the object is used, but from only looking at the class itself, I figured its possible to simply generate the prompt when needed. |
Improves the typing of the `Table` component family. We strictly consider the internal interface for actions and columns, because there is no explicit rendering for them. In the future we might extend the public interfaces so custom implementations become possible.
Change `UI\Component\Table\Action\Factory` method signatures to also accept `UI\Component\Prompt\Prompt`. This changes the behaviour of Table Actions conceptually, since Prompts are asynchronous by default. This makes `UI\Component\Table\Action\Action::withAsync()` obsolete, which is why this method has been deprecated. To incorporate Prompt's into Table Action's they were modified to work with an `UI\URLBuilder` instead of an `ILIAS\Data\URI`.
Addendum to b81d729 which replaces usages with `ILIAS\Data\URI` when creating a Prompt or its Show Signal.
thibsy
force-pushed
the
feature/12/ui-data-table-prompts
branch
from
November 9, 2026 09:44
400cc37 to
5879782
Compare
Contributor
Author
|
@mjansenDatabay / @lscharmer I don't think the pipelines have something to do with these changes. Perhaps some libxml issue? |
Contributor
|
@thibsy Yes, these are the issues I mentioned in the JF. @lscharmer provided a PR here #12363 |
Contributor
Author
|
@mjansenDatabay sorry missed that part then. Thx for the info! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
This basically applies #7809 to the latest trunk. It already contains my review and its corrections, so this should be ready to merge after @oliversamoila looked it over inside the GUI.
Also contains one small improvement commit which made reviewing the code much easier (proper typing). I also added a roadmap entry about refactoring the table internals, because this grew into quite a mess IMHO.
Kind regards,
@thibsy