Repository navigation
Conversation
Re-read the object before calling update(), so the translation is written with the stored values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://mantis.ilias.de/view.php?id=47003, alternative to #10981.
ilContainer::update()writes the translation from the object's legacy title/description, and those still hold the old values afterstorePropertyTitleAndDescription(). Soobject_translationwas always one save behindobject_data, and copies got the outdated title.The fix re-reads the object right before
update(). That way we don't need theilObjectsetters and the change stays inside the LSO. Everything from the form is already stored at that point, so nothing gets lost.Tested on 10, 11, 12 and trunk, and the commit can be cherry-picked as is. On 12 and trunk the LOM title is one save behind as well, and this fixes it too.