Repository navigation
Conversation
rammann
changed the title
interiorDelete bug
aaadelmann
approved these changes
Oct 19, 2026
rammann
enabled auto-merge
October 19, 2026 08:51
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue #615.
The bug came from the ambiguity of
maxDeleteIndex=0, which occurred when there was one invalid particle at index 0 in the valid region, but also when there was no invalid particle in the valid region. The latter is what cause the bug described in #615.If we count the number of positive entries in
locDeleteIndexdirectly instead of finding the largest index oflocDeleteIndexwhich is positive. This way the prior case above correctly count 1 and the latter (buggy) case 0. We then directly destroy with the count instead of index+1.Closes #615.