Repository navigation
Support multiple certificates for key rollover - #351
Merged
theseal merged 1 commit intoNov 3, 2026
Merged
Conversation
check_signature now accepts an iterable of verifiers (certificate files, PEM text or SHA1 fingerprints). A signature by any one is accepted. MDSL entries now verify against all listed certificates directly instead of pinning the first fingerprint, so a rollover can list both the old and the new signer. `load` accepts a repeated `verify`, and ResourceOpts.verify is now a list Requires pybergshamra >= 0.11.1. Closes IdentityPython#300 (rather replaces…)
kushaldas
approved these changes
Nov 2, 2026
kushaldas
left a comment
kushaldas
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me.
|
As far as I can see it looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_signature now accepts an iterable of verifiers (certificate files, PEM text or SHA1 fingerprints). A signature by any one is accepted.
MDSL entries now verify against all listed certificates directly instead of pinning the first fingerprint, so a rollover can list both the old and the new signer.
loadaccepts a repeatedverify, and ResourceOpts.verify is now a listRequires pybergshamra >= 0.11.1.
Closes #300 (rather replaces…)