You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Clarify import review counts and untouched field validation - #74
Label review findings, import warnings/errors, field-review counts, and health-scan check counts by what they actually measure.
Keep required-field markers visible while deferring error styling/messages on untouched fields, including after import. Reset touched state when a new import succeeds; show all field errors when the user attempts an invalid export.
Preserve the existing metadata validation and export blocking logic.
Add SSR rendering tests for required, touched, and export-attempt states and tests for review headline categories.
Validation
npm run test (106 passed)
npm run build (passed)
Independent branch based on main; does not change PR #64.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Author reordering and removal do not remap touched-state keys, causing validation errors to disappear when an edited author's row index changes.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Remap author touched state when reordering or removing authors
src/components/MetadataForm.jsx:32
After a successful import, editing the second author's ORCID to an invalid value and moving that author up hides the error: the error moves to index 0, but the touched key remains authors.1.orcid. Removing an earlier author has the same effect because reorderAuthor and removeAuthor in src/App.jsx update row indexes without remapping touched state. Remap per-author touched keys in both handlers so error visibility follows the edited author.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
designUX or presentation needs attentionenhancementNew feature or request
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55
Changes
Validation
npm run test(106 passed)npm run build(passed)Independent branch based on
main; does not change PR #64.