Repository navigation
fix(cli): align extension management with v2 and clarify contribution requirements - #153
Merged
Merged
Conversation
- 区分主要实现 scope 与独立发布项目范围 - 补齐 fork CI、安装依赖和 CLI 验证说明
- 使用 Peer selection API 并保留取消选择回执 - 从当前 Peer 状态发现配置 schema,增加 status 命令 - 添加 HTTP 边界回归测试和破坏性变更片段
This was referenced Oct 22, 2026
Closed
11 tasks done
- Preserve current main changes before reviewing contribution delivery.
- Keep the new v2 selection and release instructions accessible to community contributors.
xiaoland
marked this pull request as ready for review
October 26, 2026 07:11
- Preserve the breaking command and API requirements in the public release note.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
The released CLI uses an obsolete extension installation endpoint, which returns 405 against the current Core. Configuration discovery also reads a schema from the shared identity after that field moved to peer status.
Use
select --distribution python|module_federation --version VERSION [--peer]andunselect [--peer]with the selection API, retain the DELETE receipt, and expose status for the connected peer. Discover configuration schema from that peer's v2 status. Update CLI and contributor documentation, add an explicit breaking-change fragment, and run three HTTP boundary regressions in the CLI check.Primary scope:
cli. Release project:inkcre-cli.Tracking issue: InKCre/.github#39.
Evidence
pdm run -p cli check: lint, format, type checking, and three unittest cases passed.pdm build -p cli: wheel and sdist built.pdm run python scripts/release.py check --base origin/mainpassed for the submitted change.Completed delivery
Merged as
15a4cce6c01eee2bb3e5f8654a802a341a304dba, then formally released as inkcre-cli 0.3.0 through #161. The public PyPI wheel passed SHA-256 verification, fresh installation, v2 command help, and the three existing HTTP-boundary regression tests. docs#47 replaced the temporary source-install instructions with the published package requirement; website delivery and public-page verification passed. The contribution tracking issue is complete.Risk and rollback
The command change is breaking: ambiguous
install/uninstallaliases are replaced rather than preserved. The release system consumes the.removed.mdfragment. No database migration is included. The published 0.3.0 package is immutable; a package correction requires a follow-up version. Restoring the old source commands would reintroduce their known 405 failure against current Core.Delivery effects
The mandatory checks and CLI checks passed on final head
f188c37; only the public release-note language changed after the previously accepted runtime evidence. Main runtime artifact, deployment, Extension release, and release-preparation workflows passed. The source-only merge kept the CLI version unchanged and its upload correctly skipped. The later formal release and guide publication are complete as recorded above; Core 0.9.0 demo maintenance also completed in #161. No submodule update was part of this PR.Related work
No stacked parent or child PR.
.github#36, docs#40, impl-ts#171, ui#64.