Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required human contributor answers
The contributor confirmed the stage scope and these answers on 2026-11-19; the detailed confirmation is retained in the contributor's task record.
Is a PR needed? Yes. The contributor authorized necessary stage draft PRs and independent supplements to existing authors' work, preserving their commits.
Bug-fix evidence: This changes test placement and documentation. At #177 head, the three head-loader test bodies live under
src/, contrary to CONTRIBUTING.md, and the parity-example command omitsVELA_NATIVE_MANIFEST_SHA256, which its loader requires. No runtime numerical defect is claimed.Summary
Keep Vela's head-loader regressions under root tests and document the independently reproduced L20 native-library profile with anchored release replay commands.
This is a stacked supplement to #175–#177. Its B-owned base is fixed to MrDongsls's #177 head
55ed516d302ad5bf1f5824f5ba53208236080a3b. Current head5679f595e9ecd324326907ba913aa8f209a36a69: three files, +62/-43. Original author history is preserved. Keep draft; integration into main requires the existing stack to land and a fresh retarget/check.Evidence
Personally executed:
GPU stdout:
Purpose
Resolve the root-test placement and runnable-example gaps while adding current target-hardware evidence. Related: #137, #169, #175, #176, #177.
Test Plan
vllm-sr/Vela-2.0-0.8B@326b01d81f61fff7fd4ae570e54b87a49119e490. Full source shard LFS SHA256c70237ecd579c60289c177fa9806e71c24840c2fc557b5c76af1395dc3081fa6. Original committed fixtures unchanged.1d789daa559b74a65c814b212ea5789d95d418d11c2f3ec67fa41267de9ecddb. Pre/post-export package gates pass.GPU-8634ad01-28fd-6f5b-a574-bf1832a8dbc8; nvcc12.8.61, Rust1.100.0. Independent checkout/venv/target/export and GPU1 functional lock.47e918cbbaebff25d62f841c98b405e8325e80e17cb3b46d979b71de3d301db5. Release executor test binary SHA256b9ef97773f086be82555f7ec5841d1a61082877f868e8d23b223e40f14d9bf0f.cargo test --release --lockedas documented. All numerical override envs unset. No source, case, structural assertion or gate was changed.Test Result
This exact L20 native-library logit profile passes the original0.35 gate. CPU head/response and processing gates also pass. The code tested is the unchanged executor/backend at55ed516 plus the root-test supplement; the subsequent commit adds recipe text only.
Native HTTP, GPU end-to-end answers, positive long-window GPU parity, 4B/9B and other hardware remain separate. The original0.8B long-span head fixture has an empty expected answer; passing it does not establish a positive long-span GPU decision. Historical RTX profile descriptions remain attributed to their sources.
Demo / evidence
The raw excerpt above is this actual run. Complete stdout, interrupted debug attempt, model metadata, environment, hashes and protocol are retained in
vela08-evidence.tar.gz, SHA2569c681b1067b38abcbf1c3fa9a63a5235eea4fff9a53edd55e48f989c7665aeb7, on both contributor-local and L20 task storage. No generated run dump or archive is added to product Git.No latency/throughput comparison or video claim. The runtime/kernel implementation is unchanged. #205's staging-base head returned no pull-request workflow run; the personally run checks above are the evidence.
Merge Danger
Door: two-way.
Blast Radius: tests.
Private test wiring and a focused recipe update only. Retarget after the existing stack lands and rerun relevant integration checks.
Self-review
Agent precheck reviewed the complete three-file supplement, registration/discovery, preserved assertions, actual profile/gates, artifact hygiene and strict docs. Human contributor checklist remains for review; no Ready/merge request.