Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required human contributor answers
The contributor confirmed this single stage on 2026-11-19: Vela #169 contract audit and acceptance wording. #137 and the native PRs provide background/evidence; implementation of the native stack and other models is outside this draft's scope. Detailed human confirmation is retained in the contributor's task record.
Is a PR needed? Yes. The contributor authorized necessary contract documentation/tests and a stage draft PR.
Observed gaps: #169 records the conflict between #137's old span/set rejection/no-truncation proposal and the shipped reference. The recipe suggested token usage as a tail-coverage check, which the actual assembly/window policy does not guarantee. Source inspection and a preparation-only repro also show distinct span coordinate origins and an unresolved cross-part-list failure. This PR changes no inference or transport behavior.
Summary
Document Vela's existing five-kind policy, clarify span coordinate origins and pending decisions, and bind a real non-BMP CPU oracle to maintained acceptance tests.
Preserve span/set extensions, upstream state truncation, model-defined confidence and actual rendered-row token accounting. The shared RFC #61 remains open. Related: #169, #137, merged #151/#174. This does not mark native/family acceptance complete.
Evidence
[10,30)after an emoji; slicing the named request field giveszhang.wei@example.cn. Independent set probabilities sum to more than1.3. The actual partial PERSON prediction is preserved without a task-accuracy claim.requestandsource; a span usesover: ["request","source"]. Mapping resolvestarget_part=["user","context"]; upstream_to_generic->_prepraisesTypeError: unhashable type: 'list'before a model forward. This is recorded as unresolved scope/error behavior, not blessed as a client-error contract.Personally executed on L20 Linux, baseline
f1e674f2d324f5bb4e1ba2162551d0b633f20be0, final candidatebfc766c103ccf529b3f277cba38550c42f04ae2e:The real-model/HTTP runs preceded the final documentation/controlled-coordinate follow-up; their inference/transport source is unchanged. With no package env, the14 upstream checks skip explicitly; ordinary tests need no weights/torch/GPU and perform no download.
Purpose
Provide #169's Vela-specific current-state/acceptance record, correct the tail-coverage advice and relative recipe links, and name the remaining decisions without changing external behavior.
Pending decisions
Test Plan
vllm-sr/Vela-2.0-0.3B@d6f03aa9baca4f9017fa8f8e9c2764d3bed3f409; repository package gate plus full model LFS SHA256bd37dd0db177d766bc554eded78ae8493bc248172d0480f6a543b30932a0cc8e.a56fc7bebdd3bfbb4edbbb80083c6a0421a7d51ab232533e869a14348f02bd0f.vela03-evidence.tar.gz, SHA256bcdaf65b82cfc10e9fd0ca8e91cae4e03b9ff077c960e8b5c1914e97ad12b1a2, is retained on contributor-local and L20 storage, with final coordinate repro/test/docs output retained separately. Raw machine logs remain outside product Git.Test Result
Scoped CPU/reference/HTTP/documentation checks pass. The earlier Windows ordinary suite had128 pass/7 failures from Linux-extension assumptions, symlink privileges and default CJK decoding; the original suite passed on Linux. New fixture consumers use explicit UTF8; unrelated platform tests are unchanged.
No external behavior, calibration or numerical gate is changed. Formal contract adoption, issue closure and native acceptance are not claimed.
Demo / evidence
The committed oracle is an actual CPU prediction captured by the documented exporter. Real direct/frontend comparisons preserve complete response bodies with no timing-field exemption. Video and performance A/B are inapplicable to this docs/contract-test change.
Merge Danger
Door: two-way.
Blast Radius: contract.
230 added Python test lines; total+616/-10, including a215-line consumed oracle. Tests import only a package accepted by the existing hash gate. The docs describe current behavior and pending policy; they do not standardize other workers.
Self-review
Agent precheck reviewed the six-file diff, owning upstream functions, production response gate, fixture provenance/consumers, ordinary-test independence and docs links. All test bodies/fixtures are under root tests. The contributor checklist remains for human review; keep draft.