fix: show paid badges in local playlists - #91
Merged
InfinityLoop1308 merged 2 commits intoAug 22, 2026
Merged
Conversation
Show the paid badge instead of duration or playback progress for paid local-playlist entries, and preserve the membership flag when converting playlist entries. Bug report: InfinityLoop1308#90
Owner
|
Thanks. I removed some code: Compose is going to be dropped, and we don't use test in this project. |
Contributor
Author
|
I'll make note of that if I have any future contributions. Thanks for your kindness and keeping this project alive, we appreciate you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlaylistStreamEntryback into aStreamInfoItem.Problem
Paid or members-only videos display a Paid badge in channel and “What’s New” feeds. The same videos display their duration after being saved to a local playlist.
The paid state is already persisted in
StreamEntity.isPaid, but the local-playlist item holder did not read it. In addition,PlaylistStreamEntry.toStreamInfoItem()did not transfer the flag toStreamInfoItem.requiresMembership.Implementation
LocalPlaylistStreamItemHoldernow:StreamEntity.isPaidbefore rendering the duration;PlaylistStreamEntry.toStreamInfoItem()now copiesisPaidusingsetRequiresMembership().The experimental Compose local-item path now uses the same paid-badge precedence and suppresses playback progress for paid entries. Its presentation logic is covered by a focused unit test.
Testing
devbranch.testDebugUnitTest.lintDebug.assembleDebug.Related issue
Refs #90
#90
Disclaimer: This PR and fix were generated with AI assistance, but I have personally read and tested the code to verify that it functions on my device and to ensure its validity. A flesh-and-blood human typed this disclaimer.