Repository navigation
Release 2.2.4 stable: protocol validation and security hardening - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepare SpectraScan 2.2.4 (stable) by closing the six protocol-validation findings identified in the release audit. This PR hardens response correlation and wire-format parsing, adds targeted regression coverage, removes an unsupported RDP vulnerability classification, and aligns the project documentation with the 2.2.4 stable release line.
This PR is intentionally isolated on
release/2.2.4; it targetsmainand does not modifymaindirectly.Security and protocol fixes
1. High — SNMP response correlation
query()so unsolicited, stale, or mismatched datagrams are rejected.2. High — RDP negotiation framing
recv()returns the entire packet.3. Medium — MongoDB response correlation
responseToto equal the outstanding request ID exactly.4. Medium — RDP NLA finding accuracy
5. Medium — RTSP malformed-response handling
6. Medium — SMTP multiline-response validation
Regression tests
Expanded
tests/test_protocol_parsers.pyto cover:responseToplus zero/mismatched correlation.Documentation and release metadata
CHANGELOG.md, including security, fixes, tests, and documentation changes.SECURITY.mdsupported-version guidance and removed the beta-only support status.VERSIONfile containing2.2.4.Validation
The repository CI workflow is configured to run:
CI status: PASSED — latest PR-head workflow run #42301773756 completed successfully across all six Linux/Windows × Python 3.10/3.11/3.12 jobs. The full regression suite passed (54 tests); Linux Bandit checks passed; the Linux/Python 3.12 pip-audit passed. Compile and startup/import smoke checks also passed in every matrix job.
Release checklist
release/2.2.4.main.v2.2.4Git tag / GitHub Release after merge.Compatibility and scope
No new runtime dependency is introduced. The changes are confined to protocol response validation, RDP finding classification, regression tests, and release documentation. Network probing remains intended for explicitly authorized targets only.