Repository navigation
Feat/ject 177 common foundation - #4
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경
Jira: JECT-177 공통 개발 브랜치·화면 개발 기반 준비하기
디자인 1차(Figma 디자인 시스템 v3)를 앱·웹·문서에 반영하고, Figma 확정 화면 기준으로 화면 이동 경로를 정했다.
1. 색 토큰 (Figma v3 이름·값)
700, Primary-Blue 50700, white·black (gray는 docs 표에만, 쓸 때 추가)context.colors.labelNormal, 웹var(--color-label-normal). Pink·Blue는 둘 다 Primary라 화면에서 바로 쓴다primary,textPrimary,border등)은 새 이름으로 교체 (사용처 8곳)2. 타이포그래피 + Pretendard
context.textStyles.body1Regular(새AppTextStyles), MaterialTextTheme에도 매핑. Pretendard 4굵기 OTF를assets/fonts/pretendard/에 넣고pubspec.yamlfonts 등록 (6MB, OFL 라이선스 포함)font: var(--text-body1-regular).pretendardnpm 패키지, 글자 범위별 subset이라 필요한 조각만 받음textTheme대신context.textStyles.*를 쓴다 (design-tokens·mobile-architecture·overview·pr-checklist 수정)3. 화면 이동 경로
와이어프레임 New→11/8 pm 확정 영역기준 경로 37개를app/routes.dart의AppRoutes에 정의 (상수 +...Of(id)함수)app/router.dart는 GoRoute 등록만. 지금은/login만 연결, 나머지는 화면 만드는 PR에서 등록docs/mobile-architecture.md11절검증
apps/mobile):dart format·flutter analyze·check_imports·flutter test(30개) 통과apps/web):format:check·lint·typecheck·test·build·build:dev통과AppRoutes의...Of(id)가 경로 상수와 같은지UI 캡처
화면 로직 변경은 없음. 글꼴(Pretendard)·기본 색·로그인 화면 제목 크기(20 → 18, Title-1(B))가 바뀜 — 캡처 첨부 예정
호환성·주의
AppRoutes분리), 의존성(pubspec.yaml폰트, 웹pretendard패키지)context.colors.*,var(--color-*),context.textStyles.*새 이름으로 맞춰야 한다리뷰 순서
docs/design-tokens.md(색·글자 표)apps/mobile/lib/shared/theme/app_colors.dart→app_typography.dart→app_theme.dartapps/web/src/shared/styles/tokens.css→global.cssapps/mobile/lib/app/routes.dart→router.dart→docs/mobile-architecture.md11절apps/mobile/test/shared/theme/app_theme_test.dart,apps/mobile/test/app/routes_test.dart새 문구
해당 없음
작성자 체크 (docs/pr-checklist.md A절)
Colors.*·숫자 크기 없음. 토큰 변경은 앱·웹·문서 함께pnpm-lock.yaml리뷰어 체크 (docs/pr-checklist.md B절)
[must]/[nit]접두사와 근거 절 번호