Skip to content

fix: backport Rails 8.1 routing keywords to release-0-9 #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bf4 merged 4 commits into from
Oct 22, 2026
Merged

fix: backport Rails 8.1 routing keywords to release-0-9 #1497

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
408c405
fix: pass routing keywords explicitly on Rails 8.1
barelyknown Oct 9, 2026
7c44f3e
test: load logger before Rails test dependencies
bf4 Oct 22, 2026
ab95500
test: honor configured route format in routing regressions
bf4 Oct 22, 2026
9976230
Merge branch 'release-0-9' into codex/rails-8-1-routing-0-9
bf4 Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/jsonapi/routing_ext.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def jsonapi_resource(*resources, &_block)
options[:except] << :destroy unless options[:except].include?(:destroy) || options[:except].include?('destroy')
end

resource @resource_type, options do
resource @resource_type, **options do

@bf4 bf4 Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 ruby2keywords

# :nocov:
if @scope.respond_to? :[]=
# Rails 4
Expand All @@ -57,7 +57,7 @@ def jsonapi_resource(*resources, &_block)
end
else
# Rails 5
jsonapi_resource_scope(SingletonResource.new(@resource_type, api_only?, @scope[:shallow], options), @resource_type) do
jsonapi_resource_scope(SingletonResource.new(@resource_type, api_only?, @scope[:shallow], **options), @resource_type) do
if block_given?
yield
else
Expand Down Expand Up @@ -119,7 +119,7 @@ def jsonapi_resources(*resources, &_block)
options[:except] << :destroy unless options[:except].include?(:destroy) || options[:except].include?('destroy')
end

resources @resource_type, options do
resources @resource_type, **options do
# :nocov:
if @scope.respond_to? :[]=
# Rails 4
Expand All @@ -131,7 +131,7 @@ def jsonapi_resources(*resources, &_block)
end
else
# Rails 5
jsonapi_resource_scope(Resource.new(@resource_type, api_only?, @scope[:shallow], options), @resource_type) do
jsonapi_resource_scope(Resource.new(@resource_type, api_only?, @scope[:shallow], **options), @resource_type) do
if block_given?
yield
else
Expand Down
Loading