Repository navigation
ci: fix Validate job (generated client formatting + ty version pin) - #67
Merged
Merged
Conversation
…ject version - ruff format the generated http_client.py (long codegen'd signatures broke E501 and format check) - run ty via 'uv run' (project-pinned version) instead of 'uvx ty', which silently pulled the latest alpha and introduced unrelated invalid-type-form errors - make the pretalx codegen pipeline run ruff format/fix on its output so future schema syncs don't regenerate unformatted code
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
badge.file.read() opened the underlying storage file but never closed it, leaving the descriptor to be closed by GC. On CPython 3.14 this surfaces as a PytestUnraisableExceptionWarning during an unrelated test's teardown, failing Test Smoke non-deterministically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ruff formatthe generatedhttp_client.py— the pretalx codegen output had long, un-wrapped function signatures that failed bothruff check(E501) andruff format --check.tyviauv runinstead ofuvxin the Validate job, so it uses the project-pinned version fromuv.lockinstead of silently fetching whatever the latesttyalpha release is. The untrackeduvxinvocation had drifted ~70 releases ahead of the pinned version and started flaggingQuerySet[Model]annotations (a normal Django-without-stubs pattern) as errors.ruff format/ruff check --fixstep to thepretalx-codegenMakefile target so the next scheduled schema sync doesn't regenerate unformatted code and break CI again.Why
mainCI has been red since the last pretalx schema sync (#38) merged — the Validate job fails onruff checkdue to the unformatted generated client, and would also fail onty checkbecause of the version drift described above.Verification
uv run ruff check→ all checks passeduv run ruff format --check→ all files formatteduv run ty check src packages/pretalx-client/src→ exit 0 (warnings only, matching existing[tool.ty.rules]policy)uv run pytest packages/pretalx-client/tests/→ 231 passed, 4 skipped