cleanup benchmark printouts - #1394
Open
baltzell wants to merge 2 commits into
Open
Conversation
baltzell
requested review from
c-dilks
and
a lite review from Copilot
and removed request for
raffaelladevita and
zieglerv
August 22, 2026 00:53
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes and simplifies benchmark/timeout printout strings to be shorter and more consistent across benchmark timer types.
Changes:
- Simplified
BenchmarkTimerandBenchmarkTimerTotaltoString()output format (labels and alignment). - Adjusted the benchmark report header capitalization in
Benchmark.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| common-tools/clas-utils/src/main/java/org/jlab/utils/benchmark/BenchmarkTimerTotal.java | Updates total-timer toString() formatting to the new concise style. |
| common-tools/clas-utils/src/main/java/org/jlab/utils/benchmark/BenchmarkTimer.java | Updates per-timer toString() formatting to the new concise style. |
| common-tools/clas-utils/src/main/java/org/jlab/utils/benchmark/Benchmark.java | Tweaks benchmark results header capitalization for cleaner output. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
baltzell
enabled auto-merge (squash)
August 22, 2026 02:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.