Skip to content

fix thread safety for newly parallell Benchmark #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
baltzell wants to merge 1 commit into
base: development
Choose a base branch
from
Open

fix thread safety for newly parallell Benchmark #1403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions common-tools/clas-utils/src/main/java/org/jlab/utils/benchmark/Benchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,36 +39,34 @@ public void reset(){
bt.reset();
}

public void addTimer(String name){
public synchronized void addTimer(String name){
if (!timerStore.containsKey(name))
timerStore.put(name, new BenchmarkMultiTimer(name));
else
System.err.println("[Benchmark] -----> error. timer with name ("+ name + ") already exists");
}

public void pause(String name){
if (!timerStore.containsKey(name))
timerStore.put(name, new BenchmarkMultiTimer(name));
addTimer(name);
else
timerStore.get(name).pause();
}

public void resume(String name){
if (!timerStore.containsKey(name))
timerStore.put(name, new BenchmarkMultiTimer(name));
addTimer(name);
timerStore.get(name).resume();
}

public void pause(int thread, String name){
if (!timerStore.containsKey(name))
timerStore.put(name, new BenchmarkMultiTimer(name));
addTimer(name);
else
timerStore.get(name).pause(thread);
}

public void resume(int thread, String name){
if (!timerStore.containsKey(name))
timerStore.put(name, new BenchmarkMultiTimer(name));
addTimer(name);
timerStore.get(name).resume(thread);
}

Expand Down
Loading