Repository navigation
Fix bugs: AHDC waveform requalification - #1566
Merged
Merged
Conversation
ftouchte
requested review from
N-Plx,
baltzell,
efuchey,
mathieuouillon,
mpaolone,
raffaelladevita and
whit2333
as code owners
November 3, 2026 13:46
baltzell
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request I re-qualified these wfType 4 into wfType 2.
Moreover, as the ToT is not properly defined for the saturated signals (wfType 1) and for the missing trailing edge signals (wfType 2), I removed this cut in the Hit Selection.
This correction has a small effect of the reconstructed data as most of these waveforms are out of time.
However, I observed a small increase, about 1%, of the number of reconstructed elastic events. Tested on run 22772, He4 target, 2.24 GeV.