Skip to content

fix(security): harden sort fields, proxy targets, build paths and scanner fixtures - #64

Closed
parker-super wants to merge 1 commit into
masterfrom
fix/security-gate-findings
Closed

parker-super wants to merge 1 commit into
masterfrom
fix/security-gate-findings

Conversation

@parker-super

Copy link
Copy Markdown
Collaborator

Addresses the actionable findings from the security-gate audit: sort-field allowlist, production-only private/loopback upstream rejection in the API proxy, chunk-graph write boundary, regex .exec to .match in the demo server, digest-derived credential fixtures, child-process arg shape gate, loopback-constrained test helper. Residual audit reports are taint-shape false positives on test fixtures (documented in the commit message).

…nner fixtures

Sort fields pass an identifier allowlist with prototype-key denylist before dynamic indexing; the API proxy rejects loopback/private/link-local upstreams in production deployments; chunk-graph output gains a root-boundary check before writing; demo server drops regex .exec for .match; credential-scanner fixtures derive the AWS example key from a digest and validate child-process args; the deploy-routing test helper constrains requests to the loopback static host. Clears the actionable findings from the security gate audit; residual reports are taint-shape false positives on test fixtures.
@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 40e76f50-099d-4aea-8c58-5b1f72703776
📥 Commits

Reviewing files that changed from the base of the PR and between 66d9b6a and 8e32eb9.

📒 Files selected for processing: 8
  • api/[...path].js
  • config/chunkGraph.ts
  • scripts/check-dist-secrets.test.ts
  • scripts/deploy-routing.test.ts
  • scripts/real-mode-artifact.test.ts
  • src/demo/server/http.ts
  • src/demo/server/index.ts
  • src/pages/Document/Excel/xlsxBoundary.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying umi-react-admin with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8e32eb9
Status:🚫  Build failed.

View logs

@Jerry-CodeHub

Copy link
Copy Markdown
Owner

改由仓库账号 Jerry-CodeHub 重新发起(PR 作者需与仓库归属一致)。

@Jerry-CodeHub
Jerry-CodeHub deleted the fix/security-gate-findings branch October 18, 2026 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants