Repository navigation
fix(layout): click-open header menus and pixel-calibrated account chip - #70
Merged
Merged
Conversation
Header dropdowns open on click only (hover-pop menus read as stray tooltips); icon buttons get a visible fill-secondary hover; the ProLayout-painted backdrop behind the actions cluster is suppressed so the account chip shows a single background layer; the chip is an outlined avatar + name + caret, and the avatar glyph is vertically re-centered via measured margin compensation (baseline placement sat ~1.4px high in both scripts, latin also ~0.5px right).
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 47 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…down The reset-demo flow hovered the avatar to open the account menu; the header fix made dropdowns click-only, so the menu-item click timed out.
Deploying umi-react-admin with
|
| Latest commit: |
ff54cf1
|
| Status: | 🚫 Build failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Header dropdowns open on click only; icon-button hover raised to fill-secondary; ProLayout container backdrop suppressed for a single-layer account chip (outlined avatar + name + caret); avatar glyph centered via measured margin compensation (was ~1.4px high in both scripts).