Repository navigation
Conversation
The README Docker snippet used `JohnnyMorganz/StyLua:2.6.0` as the `COPY --from` image. Docker image references must be lowercase, so this fails with "invalid reference format: repository name must be lowercase". Use `johnnymorganz/stylua`, the name the release workflow publishes to Docker Hub, and update the matching needle in .github/release.py so the version keeps being bumped on release. Also fix typos: - README.md: preseve -> preserve - src/shape.rs: expontential -> exponential - src/formatters/functions.rs: COMPATABILITY -> COMPATIBILITY - src/cli/main.rs: Covert -> Convert
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Docker install snippet in the README fails to build:
COPY --from=JohnnyMorganz/StyLua:2.6.0 /stylua /usr/bin/styluaDocker image references must be lowercase, so this fails with
invalid reference format: repository name must be lowercase. The image is published asjohnnymorganz/stylua(theimages:value inrelease.yml, and the Docker Hub link just above the snippet), so the snippet now uses that name..github/release.pybumps this line with a case-sensitiveStyLua:{old}match, so I changed that needle tostylua:{old}as well. Otherwise the Docker tag would stop updating on release. The new needle matches only the Docker line, since the-- stylua: ignoreexamples have no version after the colon.Also fixes four typos:
README.md: preseve -> preservesrc/shape.rs: expontential -> exponential (doc comment)src/formatters/functions.rs: COMPATABILITY -> COMPATIBILITY (comment)src/cli/main.rs: Covert -> Convert (comment)Only comments changed in the Rust files. No code changes there.