added: slightly reduce precompilation time - #439
Merged
Conversation
From ~ 500 sec to ~ 375 sec. It should not affect TTFX too much in most cases.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
=======================================
Coverage 97.17% 97.17%
=======================================
Files 27 27
Lines 6270 6270
=======================================
Hits 6093 6093
Misses 177 177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Member
Author
|
Merging, the CI run times are comparable to #438, but the precompilation time is significantly decreased. Moreover, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precompilation was taking ~ 500 sec, down to ~ 375 sec now.
I tried to remove calls that are redundant, reduced the size of the optimization problems in the workload, and removed construction of types that I consider less important (for exemple:
ExtendedKalmanFilter, the default isUnscentedKalmanFilter, which is generally considered a better alternative toExtendedKalmanFilter). It should not affect TTFX too much in most cases.