Prevent type inference from re-executing DDL - #354
Merged
Conversation
Only scan rows to infer stored types for strict queries that returned SQLITE_ROW. Treat every non-ROW result as terminal. This prevents schema-changing statements with hidden result columns from being re-executed after SQLITE_DONE and spinning on SQLITE_ERROR. Fixes #353
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SQLITE_ROWALTER TABLE ... ADD COLUMNon strict tables in normal and strict result modesSQLite can expose a hidden result column for this schema change. SQLite.jl previously re-stepped the completed statement while inferring that column's type. The schema change then ran again, returned
SQLITE_ERROR, and the scan loop continued forever.Validation
Test.detect_ambiguities(SQLite; recursive=true)reports no ambiguitiesFixes #353
Co-authored by Codex