Repository navigation
Compare OASIS property values strictly before writing them as repeated - #2508
Closed
nikosavola wants to merge 2 commits into
Closed
nikosavola wants to merge 2 commits into
nikosavola wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2507
The OASIS writer can write a property value as "same as the last one" to save space. It used$2^{56}$ and $2^{56}-1$ , or $10^{13}$ and $10^{13}+1$ , counted as equal. The same was true for $5$ and $5.0$ . The second shape then got the value of the first one when the file was read back.
Variant::operator==to check this. That operator compares integers as doubles and allows a small tolerance. So values likeThe writer now compares each value with
Variant::equal. This needs the same type and an exact match for integers. Doubles still use the small tolerance. The properties repository does the same.The new test writes pairs of shapes with these values and reads them back. It checks that each shape keeps its value and that integers stay integers. It fails on master and passes with the fix.