Repository navigation
nodebb.py draws its password box on the terminal, not in the hook's pipe - #17
Merged
Merged
Conversation
…k's pipe 40nodebb reads nodebb.py's standard output for APP_PASS=, and dialog draws on standard output, so an interactive first boot would freeze with the box drawn into the pipe (the bug keel-wordpress 19.0-3 hit on Proxmox on 2026-09-30, keel-mariadb#20). The answers go to a duplicate of that pipe and standard output becomes the terminal the hook checked on standard input, else /dev/tty; without either the script names secrets.app_password instead of a traceback. tests/dialog.bats runs the script as the hook does inside script(1) and fails on the old code.
marcos-mendez
added a commit
that referenced
this pull request
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
firstboot.d/40nodebbreadsbin/nodebb.py's standard output forAPP_PASS=, and dialog draws on standard output, so an interactive first boot would freeze with the box drawn into the hook's pipe: the bug keel-wordpress 19.0-3 hit on Proxmox on 2026-09-30, fixed for dbpass.py in Keel-Linux/keel-mariadb#20.Fix: the same pattern. nodebb.py keeps a duplicate of the pipe for the KEY=value answers and points standard output, which dialog inherits, at the terminal the hook checked on standard input (else /dev/tty). Without any terminal it exits with a message naming secrets.app_password instead of a traceback. The hook is unchanged.
Tests:
tests/dialog.batsruns the script as the hook does, output redirected, inside a real pseudo terminal (script(1)), with a libinithooks stand-in whose get_password refuses unless fd 1 is a terminal; it fails on the old code and passes on the new.