Skip to content

Fix vkcube X11 resize flicker with _NET_WM_SYNC_REQUEST - #1273

Open
mohansur wants to merge 4 commits into
KhronosGroup:mainfrom
mohansur:x11_sync_request
Open

mohansur wants to merge 4 commits into
KhronosGroup:mainfrom
mohansur:x11_sync_request

Conversation

@mohansur

@mohansur mohansur commented Nov 5, 2026 •

Copy link
Copy Markdown

On X11, vkcube flickers while its window is resized.

  • Implement _NET_WM_SYNC_REQUEST for both xcb and xlib code paths.
  • Release the counter only once the new-size frame has reached the window. This uses VK_KHR_present_wait when the driver supports it.
  • otherwise waits for the next present at the new size, though this way is not guaranteed to avoid the flicker, in my testing this looks fine as well.

Tested on gnome-shell & kwin compositor.

Developed with assistance from Claude, i reviewed and tested the changes.

Closes: #1272

@ci-tester-lunarg

Copy link
Copy Markdown

User mohansur not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg

Copy link
Copy Markdown

User mohansur not on autobuild list. Waiting for curator authorization before starting CI build.

@CLAassistant

CLAassistant commented Nov 5, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@mohansur
mohansur marked this pull request as draft November 5, 2026 13:56
@ci-tester-lunarg

Copy link
Copy Markdown

User mohansur not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg

Copy link
Copy Markdown

User mohansur not on autobuild list. Waiting for curator authorization before starting CI build.

@mohansur
mohansur marked this pull request as ready for review November 5, 2026 15:01
@ci-tester-lunarg

Copy link
Copy Markdown

User mohansur not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg

Copy link
Copy Markdown

User mohansur not on autobuild list. Waiting for curator authorization before starting CI build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VKCube displays a blank screen during active window resizing

3 participants