Repository navigation
refactor(cloud-agent): remove shared sandbox allocation - #9781
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryRe-reviewed the rebased HEAD ( Assumptions: Files Reviewed (51 files)
Previous Review Summary (commit 8143640)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 8143640)Status: No Issues Found | Recommendation: Merge Executive SummaryThe shared-sandbox removal is internally consistent: new-session paths reject Assumptions: Files Reviewed (51 files)
Reviewed by deepseek-flash-latest · Input: 134.5K · Output: 20K · Cached: 3.7M Review guidance: REVIEW.md from base branch |
One sandbox serves one workspace. Nothing creates an owner-scoped shared sandbox any more: - generateSandboxId and selectControlPlaneSandbox derive only per-session keys and reject an explicit cloudflare-shared allocation. - Remove the shared route, its failover KV namespace binding (SHARED_SANDBOX_OVERRIDES) and PER_SESSION_SANDBOX_ORG_IDS. - Remove the shared-only subagent and spawn-authority checks from registration; a recorded shared kind in the operation ledger now fails with the retired-allocation message instead of being replayed. Stored data keeps decoding: the cloudflare-shared allocation, the shared sandbox kind, the metadata sandboxRoute and the legacy shared key classes stay in the schemas as legacy decode only. Such sessions ran on the retired Cloudflare Sandbox runtime, so they already stop with the retired-runtime message; saved settings, environments and triggers that name the shared allocation fall through to the default.
eshurakov
force-pushed
the
eshurakov/remove-shared-sandbox
branch
from
November 4, 2026 15:37
8143640 to
42d4b62
Compare
chrarnoldus
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One sandbox serves one workspace. #9689 already made
cloudflare-sharedunselectable, so this PR removes the shared sandbox code that nothing reaches now. Users see no difference.generateSandboxIdandselectControlPlaneSandboxderive only per-session keys. An explicitcloudflare-sharedallocation fails with the retired-allocation message.shared-sandbox-route.ts), theSHARED_SANDBOX_OVERRIDESKV binding andPER_SESSION_SANDBOX_ORG_IDS.docs/control-plane.mdand the related READMEs now state that one sandbox serves one workspace.Stored data still decodes. The
cloudflare-sharedallocation, the shared sandbox kind, the metadatasandboxRouteand the legacy shared key classes stay in the schemas as legacy decode only. Those sessions ran on the retired Cloudflare Sandbox runtime, so they already stop with the retired-runtime message. Saved settings, environments and triggers that name the shared allocation use the default.No PostgreSQL migration and no public API change.
Verification
cloud-agent-nexttypecheck and lint pass.pnpm run build:wrapper): 790 passed, 2 skipped.worker-utilstests: 1198 passed.Visual Changes
N/A
Reviewer Notes
SHARED_SANDBOX_OVERRIDESKV namespace and thePER_SESSION_SANDBOX_ORG_IDSsecret.worker-configuration.d.tswas edited by hand. Its header hash is stale; regenerate it with the private env file.apps/web/src/routers/admin/session-container-telemetry.ts) labels everysbx-ID as "Shared container". The fix must read the stored sandbox kind, because the ID prefix does not identify it.cloudflare-shared, and the request then fails as retired. Narrowing them changescatalog.json, so it is left for a separate change.sharedaction and the session-ingestkind: 'shared'mean sibling chats in one workspace, not a shared sandbox. They are not changed.