Posts: Replace wordpress/posts with v4/posts endpoint - #130
Draft
n7studios wants to merge 2 commits into
Draft
Conversation
…st() tests TestsTrait from the PHP SDK now contain the tests, as get_posts() and get_post() use the `v4/posts` endpoint, replacing the `wordpress/posts` endpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the overrides in
ConvertKit_API_V4forget_posts()andget_post()that would query the privatewordpress/postsendpoint.Calls to
get_posts()andget_post()methods are now handled by theConvertKit_API_Traitstrait, which queries thev4/postsendpoint.This mirrors the PHP SDK.
Testing
Removed the test overrides in APINoDataTest and APITest. Tests responsible for get_posts() and get_post() are now handled by the
TestsTrait.Again, this mirrors the PHP SDK.
Checklist