Repository navigation
Fix #425, #427: Donut toolbar counts both faces, search boxes clear - #434
Merged
Merged
Conversation
… search per donut (KnifeLemon#425, KnifeLemon#427) A profile's badge shows the back face's slices too ("8 · 3", with Front / Back in its tooltip). The search boxes get Fluent's clear button, and choosing another donut clears the preset search typed for the last one.
This was referenced Oct 22, 2026
KnifeLemon
approved these changes
Oct 22, 2026
KnifeLemon
left a comment
Owner
There was a problem hiding this comment.
Thanks @cre8ive-marketing. Both fixes are small and to the point: the badge shows the back face only when there is one, the tooltip reuses the existing Front/Back strings, Fluent's clear button needs no new code, and clearing the palette search on a profile switch matches what AddGroup already does. I ran the ToolbarPage tests locally and they pass.
One small thing we may tidy when merging: for a donut without a back face the tooltip reads "Front 3 · Back 0"; just "Front 3" would match the badge. CI for fork runs is waiting for approval; we'll start it and merge once it's green.
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes two bugs on Settings → Donut toolbar, both reported by @adnan-bhaldar:
ProfileItemViewModel.Countshows the back face too when it has slices:10 · 9. A donut without a back face still shows one number, as before. The badge's tooltip (CountTip) names the faces, using the existingtoolbar.face_front/toolbar.face_backstrings, so there are no new UI strings: "Front 10 · Back 9". It updates with every change throughRefresh, like the old count.Classes="search": Donut toolbar ×2, Presets page, Home) gets Fluent'sclearButtonclass: an × appears in a focused box with text. (2)OnSelectedProfileChangedclearsPaletteSearch, asAddGroupalready did. The profile list's own search is left alone, because it filters the list being clicked.No settings schema change, and no overlap with my other open PRs (#349, #351, #393, #401, #429, #432).
How was it tested?
dotnet format --verify-no-changesdotnet testwith FFmpeg 9.0.2 and rhwp 0.8.7: Platform 48, Core 454, Cli 27, Setup 145, Engines 1460, App 809 pass, none fail.ToolbarEditorTests.cs(ToolbarPageTests):A_profile_counts_both_faces_and_switching_profiles_clears_the_preset_search:Search_boxes_have_a_clear_button: both search boxes on the page have the class, the × is visible in the focused box with text, and it saves the screenshot below.A_new_group_heads_the_available_presets_and_every_profile_count_stays_right,Reset_puts_a_built_in_profile_back_and_the_list_follows) compared the badge with the front count only. They now expectfront · back.Screenshots (UI changes)
Both faces counted in the profile list, and the × in the preset search (from the new test):
Checklist
src/Filee.App/Assets/i18n/*.jsonfiles (none added; the tooltip reuses Front / Back)THIRD-PARTY-NOTICES.md(none)Fixes #425. Fixes #427.