Skip to content

feat: recognize .png_large and .jpg_large as PNG/JPEG input aliases - #470

Closed
Nitjsefnie wants to merge 2 commits into
KnifeLemon:mainfrom
Nitjsefnie-OSC:feat/461-image-extension-aliases
Closed

Nitjsefnie wants to merge 2 commits into
KnifeLemon:mainfrom
Nitjsefnie-OSC:feat/461-image-extension-aliases

Conversation

@Nitjsefnie

@Nitjsefnie Nitjsefnie commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

What does this change?

.png_large and .jpg_large files (PNG/JPEG content saved under download-style names) are now recognized as the existing PNG and JPEG formats and convert like any other image. Stored image profiles learn the new aliases through a schema-39 migration that reuses the existing extension-learning helper, so custom extension assignments stay intact.

Fixes #461

Type of change

  • Bug fix
  • New feature or improvement
  • New format or engine
  • Translation
  • Documentation
  • Build, CI or dependencies

How was it tested?

  • dotnet format --verify-no-changes
  • dotnet test
  • Tried it in the app (what you converted or clicked, and on which OS):

CI on the exact head of this branch runs the format check and the full test suite, including the new cases: detection of both aliases (lowercase and mixed case, with an unknown-suffix negative control), profile migration (idempotency, removed extensions stay removed, custom uppercase claims preserved for both aliases), and real-payload conversion of .png_large/.jpg_large files to PNG on Linux, macOS and Windows.

Checklist

  • New UI strings are in all src/Filee.App/Assets/i18n/*.json files (n/a: no new UI strings)
  • New third-party code or binaries are listed in THIRD-PARTY-NOTICES.md (n/a: no third-party code or binaries)
  • The PR does one thing (unrelated changes go in a separate PR)

Footer

Generated by GLM-5.3-Flash (lead, orchestration), GPT-6.1 Sol (implementation, review), GPT-6 Astra (review)

@github-actions github-actions Bot added the feature New features label Oct 23, 2026
@KnifeLemon KnifeLemon mentioned this pull request Oct 23, 2026
1 task done
@KnifeLemon KnifeLemon added formats New formats and engines and removed feature New features labels Oct 23, 2026

@KnifeLemon KnifeLemon left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Nitjsefnie, this is a tidy one: the two aliases map to the existing PNG and JPEG formats, the migration reuses LearnExtensions so extensions someone moved to their own donut stay there, and the tests cover detection, the upgrade and a real conversion on every OS.

Two things I'll take care of when merging, nothing for you to do:

  • CHANGELOG.md: the line went under the 2.0.0 section, which is already released. We write the changelog when we release, so I'll take it out of this PR.
  • Settings schema: #429 and #474 also use 39. We assign the numbers at merge time, in merge order, so this migration may end up as 40 or 41; I'll renumber it then.

It'll be in the next release.

Nitjsefnie and others added 2 commits October 23, 2026 08:58
Register png_large and jpg_large as aliases of the existing image formats. Upgrade stored image profiles through schema 39 using the existing extension migration helper so custom assignments remain intact.

Add detection, mixed-case, profile migration and real image conversion coverage, and document the user-facing fix.

Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
The changelog is written at release time, and the line sat under the
already-released 2.0.0 section.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Nitjsefnie
Nitjsefnie marked this pull request as draft October 23, 2026 06:58
@Nitjsefnie
Nitjsefnie force-pushed the feat/461-image-extension-aliases branch from 7f0e13d to f372510 Compare October 23, 2026 06:58
@Nitjsefnie
Nitjsefnie marked this pull request as ready for review October 23, 2026 07:30
@Nitjsefnie

Copy link
Copy Markdown
Contributor Author

Thanks! I removed the CHANGELOG line in f372510 and rebased onto current main, so that one is already off your list; the schema number is yours to set at merge.

@Nitjsefnie

Copy link
Copy Markdown
Contributor Author

Heads-up: this branch lives in an organization-owned fork, and GitHub doesn't let maintainers push to those. If anything needs changing, just say so here and I'll make the change on this branch right away.

@KnifeLemon

Copy link
Copy Markdown
Owner

Thanks @Nitjsefnie! The CHANGELOG fix is in. Main moved under this PR (#474 took settings schema 39), and since the fork belongs to an organization GitHub doesn't let us push to it, so I've opened #493 with your commits as they are plus the merge and the schema bump to 40. Closing this one in favour of it; your commits keep your authorship.

@KnifeLemon KnifeLemon closed this Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

formats New formats and engines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Format request: .png_large, .jpg_large

2 participants