Detail licences - #18
Merged
Merged
Conversation
| located at | ||
| <http://svn.slimdevices.com/repos/slim/7.3/trunk/platforms/readynas/cont | ||
| rib/scanner> | ||
| http://svn.slimdevices.com/repos/slim/7.3/trunk/platforms/readynas/contrib/scanner |
Member
There was a problem hiding this comment.
Should we update this URL? I'd have to find out whether this survived the transition to Github.
Author
There was a problem hiding this comment.
Looks like it did survive: https://github.com/LMS-Community/slimserver-platforms/tree/public/7.3/readynas/contrib/scanner
I don't see why we wouldn't update it (in a separate pull request). I see that the directory is present in every branch from public/7.1 to public/8.5 inclusive, and I guess we'd point to either the earliest or the latest.
michaelherger
left a comment
michaelherger
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for dealing with these details! I like it when someone takes action.
I have a few minor questions below.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses https://rt.cpan.org/Public/Bug/Display.html?id=132450 and https://bugzilla.redhat.com/show_bug.cgi?id=2519524.